Fixed a test. #2390
Merged
Fixed a test. #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does raise a question though: I'm guessing the 10 second delay during job host init delays recognition of the job submission timeout (presumably until the suite shuts down) because job host init is done synchronously in the main process, so a delay there holds up everything. I suppose that's unlikely to cause serious problems in a real suite, but maybe it would be better to do the host init in the process pool as part of the first job submission to that host?? |
|
(See also #2292.) |
matthewrmshin
approved these changes
Aug 10, 2017
|
One review is enough for this. |
Nice comeback - I'd forgotten about that one 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my laptop VM,
tests/events/01-task.talways passes at home, and always fails when on the work network because an expected job submission timeout event apparently does not occur.The test suite uses
[remote]host = NOHOSTfor one task. During job host init,ssh NOHOST ...returns immediately with "Name or service not known" at home, but it takes 10 seconds to time out and return at work. Adding a non-existent domain name as well makes it return immediately, and the test passes.