Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main loop: configurable delay and more #715

Closed
hjoliver opened this issue Oct 7, 2013 · 7 comments
Closed

main loop: configurable delay and more #715

hjoliver opened this issue Oct 7, 2013 · 7 comments

Comments

@hjoliver
Copy link
Member

hjoliver commented Oct 7, 2013

See comments #714 (comment) (and after). Current hardwired 1 sec sleep each time through these loops keeps CPU usage low, but it delays task spawning a bit and suite shutdown by a couple of seconds. Changing to say 0.1 sec results in snappier performance - good for quick test suites in particular - and faster shutdown, but higher CPU usage. So ... might be good to make this configurable as per @matthewrmshin's comment #714 (comment)

@hjoliver
Copy link
Member Author

hjoliver commented Jun 16, 2016

[meeting] - Or longer! Or dynamic. Set and check a flag. (event-driven scheduling model better)

@matthewrmshin matthewrmshin changed the title configurable loop delays in main and batch_submit threads configurable main loop delay Dec 19, 2016
@matthewrmshin matthewrmshin changed the title configurable main loop delay main loop: configurable delay and more Nov 23, 2017
@matthewrmshin
Copy link
Contributor

Related to this (somewhat) is that I would like a more direct control of the multiprocess pool using the main loop. The use of the standard library multiprocess pool has been causing headache, e.g. having to start the pool early and having child processes alive even when they are doing nothing.

A better approach is to write our own child process management logic and have it integrated with the main loop. This approach will give us more flexibility, e.g. child processes on demand, better external command management, control of number of child processes in run time, prioritisation of items in processing queue, etc.

@matthewrmshin
Copy link
Contributor

See also #2315 (comment)

@matthewrmshin
Copy link
Contributor

(Note: #2590 has introduced dynamic timing to the main loop, based on how busy it was and whether there are items in the process pool.)

@dpmatthews
Copy link
Contributor

@hjoliver - are you happy to close this? We don't have a configurable delay but hopefully the dynamic timing removes the need for this.

@matthewrmshin
Copy link
Contributor

@hjoliver I think this is superseded by #2866, which will address the issue in a more standard way?

@hjoliver
Copy link
Member Author

Yep, I'll close this; thanks for flagging it. Only 166 issues to go now 😬 ...

@matthewrmshin matthewrmshin removed this from the later milestone Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants