Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout for external commands? #2315

Closed
matthewrmshin opened this issue Jun 1, 2017 · 4 comments
Closed

timeout for external commands? #2315

matthewrmshin opened this issue Jun 1, 2017 · 4 comments
Assignees
Milestone

Comments

@matthewrmshin
Copy link
Contributor

We have recently noticed that various external commands (including service commands such cylc jobs-submit, cylc jobs-kill) launched by the suite process can hang (possibly due to OS issues?). Some are local commands, and some are run via SSH. Perhaps we need to wrap all commands with the timeout command to ensure that external commands die after a reasonable amount of time?

See also #2292 and #2302.

@matthewrmshin matthewrmshin added this to the later milestone Jun 1, 2017
@hjoliver
Copy link
Member

hjoliver commented Jun 2, 2017

What's happens if this occurs - one process pool member just hangs forever?

@matthewrmshin
Copy link
Contributor Author

Yes, they probably just hang forever. One thing I have mentioned before is to have the main loop manages the external command processes directly, instead of via a process pool. This should allow us a much better control over hung processes - e.g. we can have event notification of external command timeouts and allow users to tell the suite to kill them via the suite API.

@dvalters dvalters self-assigned this Jun 12, 2017
@dvalters dvalters removed their assignment Oct 18, 2017
@oliver-sanders
Copy link
Member

See also #2468 (comment)

@matthewrmshin
Copy link
Contributor Author

Original intention fixed by #2659. With that, I don't think there is a strong requirement the extra stuff mentioned in my previous comment. Closing issue.

@matthewrmshin matthewrmshin modified the milestones: soon, next release May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants