skip unset symdirs from global cfg

cylc · Jun 16, 2021 · 8f0883c · 8f0883c
1 parent a53aa02
commit 8f0883c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cylc/flow/pathutil.py b/cylc/flow/pathutil.py
@@ -191,11 +191,11 @@ def get_dirs_to_symlink(
     if install_target not in symlink_conf.keys():
         return dirs_to_symlink
     base_dir = symlink_conf[install_target]["run"]
-    if base_dir is not None:
+    if base_dir not in [None, '']:
         dirs_to_symlink['run'] = os.path.join(base_dir, 'cylc-run', flow_name)
     for dir_ in ['log', 'share', 'share/cycle', 'work']:
         link = symlink_conf[install_target].get(dir_, None)
-        if link is None or link == base_dir:
+        if link in [None, '', base_dir]:
             continue
         dirs_to_symlink[dir_] = os.path.join(link, 'cylc-run', flow_name, dir_)
     return dirs_to_symlink

diff --git a/cylc/flow/scripts/install.py b/cylc/flow/scripts/install.py
@@ -215,7 +215,6 @@ def install(
         cli_symdirs = {}
     elif opts.symlink_dirs:
         cli_symdirs = get_sym_dirs(opts.symlink_dirs)
-
     source_dir, rundir, _flow_name = install_workflow(
         flow_name=flow_name,
         source=source,