Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems superagent's function for DELETE requests is called
del
rather thandelete
, which means that as it stands now, if the input Observable (i.e. theHTTP
sink ofmain
) emits an object like{url:
http://foo.bar`, method:DELETE
}, then the driver tries to call
superagent[delete
]`, which doesn't exist. I imagine that's not the desired behavior, though let me know if there's a reason that it is.I'm new to this sort of thing, so let me know if there's something I should have done differently. It says the CI check failed for lack of credentials, but I imagine I'm not supposed to have whatever credentials those are. Is that what's supposed to happen?