Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DELETE as request method #23

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Allow DELETE as request method #23

merged 1 commit into from
Nov 10, 2015

Conversation

benjyhirsch
Copy link
Contributor

It seems superagent's function for DELETE requests is called del rather than delete, which means that as it stands now, if the input Observable (i.e. the HTTP sink of main) emits an object like {url: http://foo.bar`, method: DELETE}, then the driver tries to call superagent[delete]`, which doesn't exist. I imagine that's not the desired behavior, though let me know if there's a reason that it is.

I'm new to this sort of thing, so let me know if there's something I should have done differently. It says the CI check failed for lack of credentials, but I imagine I'm not supposed to have whatever credentials those are. Is that what's supposed to happen?

@staltz
Copy link
Member

staltz commented Nov 10, 2015

Great, thanks.

staltz added a commit that referenced this pull request Nov 10, 2015
Allow DELETE as request method
@staltz staltz merged commit 046e714 into cyclejs:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants