Update pod-delete-rate-limiter for k8s 1.31 #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YZ775
reviewed
Feb 14, 2025
| @@ -1,70 +1,71 @@ | |||
| module github.com/cybozu/neco-containers/pod-delete-rate-limiter | |||
|
|
|||
| go 1.22.5 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
It might be that your local go version is old.
Suggested change
| go 1.23.0 | |
| go 1.23.4 |
There was a problem hiding this comment.
@YZ775 Thank you for your comment.
I've updated again using 1.23.6 but it's staying 1.23.0.
If there is no particular reason to specify the latest one, I think we can keep it as it is.
chez-shanpu
force-pushed
the
pdrl-k8s-1.31
branch
from
21d5d12 to
c6952b6
Compare
Signed-off-by: Tomoki Sugiura <[email protected]>
chez-shanpu
force-pushed
the
pdrl-k8s-1.31
branch
from
c6952b6 to
ebe9a65
Compare
|
@YZ775 I forgot to update the Dockerfile. Could you check it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.