Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate teleport-node container to ghcr.io #1200

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Migrate teleport-node container to ghcr.io #1200

merged 2 commits into from
Jan 17, 2024

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Jan 12, 2024

This PR:

  • migrates teleport-node to ghcr.io.
  • automatically decides if scan is needed.
    • it checks base image for containers and, if it is scratch, instruct CI to skip scanning.
    • if FROM section contains $, it aborts auto-detection and instruct user to manually set scan flag.

Signed-off-by: Daichi Sakaue [email protected]

@yokaze yokaze self-assigned this Jan 12, 2024
@yokaze yokaze force-pushed the ghcr-teleport-node branch 4 times, most recently from 95a9cbf to e234587 Compare January 12, 2024 09:30
@yokaze yokaze marked this pull request as ready for review January 12, 2024 10:09
@yokaze yokaze requested a review from zeroalphat January 12, 2024 10:10
@yokaze yokaze force-pushed the ghcr-teleport-node branch 8 times, most recently from 906b677 to 9dd487f Compare January 12, 2024 12:38
@yokaze yokaze marked this pull request as draft January 12, 2024 12:40
@yokaze yokaze force-pushed the ghcr-teleport-node branch 3 times, most recently from d019bd0 to b2b41ce Compare January 15, 2024 06:43
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze yokaze force-pushed the ghcr-teleport-node branch from b2b41ce to 19009cb Compare January 16, 2024 01:48
@yokaze yokaze marked this pull request as ready for review January 16, 2024 02:02
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 8ff7351 into main Jan 17, 2024
74 checks passed
@yokaze yokaze deleted the ghcr-teleport-node branch January 17, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants