Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate neco-admission to ghcr.io #1181

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Migrate neco-admission to ghcr.io #1181

merged 1 commit into from
Dec 25, 2023

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Dec 18, 2023

This PR:

  • adds build_admission action to build neco-admission
  • adds extract_tags action to extract the next BRANCH and TAG and check their consistency
    • it exposes 5 outputs to use:
      • branch: image branch
      • tag: image tag
      • build: if we need to build the container
      • push: if we need to upload the container
      • docker_push: same as push, but used as the input of docker/build-push-action
  • makes build_admission and build_push use extract_tags
  • updates bmc-reverse-proxy to show a sample CI result

extract_tags echos its decision in CI output: for example,

  • nop
vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv
    Build Policy:

         branch: 
            tag: 
          build: 
           push: 
    docker_push: false
^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^
  • build only
vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv
    Build Policy:

         branch: 
            tag: ghcr.io/cybozu/bmc-reverse-proxy:0.1.25
          build: true
           push: 
    docker_push: false
^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^
  • build and push
vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv vvvvvvvvvv
    Build Policy:

         branch: 
            tag: ghcr.io/cybozu/admission:0.24.2
          build: true
           push: true
    docker_push: true
^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^

(Yes I've mistakenly uploaded ghcr.io/cybozu/admission:0.24.2 during the work for this PR...)
https://github.com/cybozu/neco-containers/actions/runs/7283597673/job/19847696899

Signed-off-by: Daichi Sakaue [email protected]

@yokaze yokaze self-assigned this Dec 18, 2023
@yokaze yokaze force-pushed the ghcr-admission branch 22 times, most recently from 42082dc to 7f1b90c Compare December 21, 2023 09:06
@yokaze yokaze requested a review from zoetrope December 21, 2023 09:18
@yokaze yokaze marked this pull request as ready for review December 21, 2023 09:18
@yokaze yokaze requested review from zeroalphat and removed request for zoetrope December 25, 2023 01:07
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 3210f18 into main Dec 25, 2023
58 checks passed
@yokaze yokaze deleted the ghcr-admission branch December 25, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants