This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Sleep before context cancellation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapih
changed the title
ymmt2005
reviewed
Jan 17, 2020
signal.go
Outdated
| delay, err := strconv.Atoi(delayStr) | ||
| if err != nil { | ||
| log.Warn("well: set default cancellation delay seconds", map[string]interface{}{ | ||
| "env": delayStr, |
There was a problem hiding this comment.
should err be added?
log.FnError: err
ymmt2005
reviewed
Jan 17, 2020
signal.go
Outdated
| @@ -28,6 +34,23 @@ func handleSignal(env *Environment) { | |||
| log.Warn("well: got signal", map[string]interface{}{ | |||
| "signal": s.String(), | |||
| }) | |||
| delayStr := os.Getenv(cancellationDelaySecondsEnv) | |||
| delay, err := strconv.Atoi(delayStr) | |||
There was a problem hiding this comment.
This should be done only when if len(delayStr) > 0.
|
@tapih Please elaborate the message body of this pull request. |
ymmt2005
reviewed
Jan 17, 2020
signal.go
Outdated
|
|
||
| func getDelaySecondsFromEnv() int { | ||
| delayStr := os.Getenv(cancellationDelaySecondsEnv) | ||
| if len(delayStr) <= 0 { |
There was a problem hiding this comment.
len never returns < 0, so this should be ==.
ymmt2005
reviewed
Jan 17, 2020
signal.go
Outdated
| log.Warn("well: round up negative cancellation delay seconds to 0s", map[string]interface{}{ | ||
| "env": delayStr, | ||
| "delay": 0, | ||
| log.FnError: err, |
There was a problem hiding this comment.
At this point, err is nil, so do not add it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To shutdown a Kubernetes Pod gracefully, the container process needs to continue accepting connections until the Pod gets removed from the service Endpoints by
kube-controller-manager.This is typically done by
/bin/sleepinpreStophook, but doing so is tedious and requires/bin/sleepin the root filesystem.This PR removes the necessity of
preStophook and/bin/sleepwith the following changes: