Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boot-ip-setter #2767

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add boot-ip-setter #2767

merged 3 commits into from
Jan 28, 2025

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Jan 7, 2025

This PR implementes #2357 .

Add a new daemon boot-ip-setter on boot servers, and it sets virtual IPs.

@masa213f masa213f force-pushed the boot-ip-setter branch 3 times, most recently from d5dcd60 to 6af14e9 Compare January 22, 2025 02:58
@masa213f masa213f changed the title wip: boot-ip-setter Add boot-ip-setter Jan 23, 2025
@masa213f masa213f requested a review from zeroalphat January 23, 2025 07:54
zeroalphat
zeroalphat previously approved these changes Jan 24, 2025
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me.
As for the parts I commented on, I think they're just a matter of preference, so feel free to merge it as is.

pkg/boot-ip-setter/main.go Outdated Show resolved Hide resolved
pkg/boot-ip-setter/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 8670e0e into main Jan 28, 2025
1 of 2 checks passed
@masa213f masa213f deleted the boot-ip-setter branch January 28, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants