Add pprof server to moco-controller #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masa213f
force-pushed
the
pprof
branch
3 times, most recently
from
169de55 to
d54dfe4
Compare
Signed-off-by: Masayuki Ishii <[email protected]>
masa213f
commented
Feb 2, 2023
| mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol) | ||
| mux.HandleFunc("/debug/pprof/trace", pprof.Trace) | ||
|
|
||
| server := &http.Server{Addr: h.bindAddr, Handler: mux} |
There was a problem hiding this comment.
I don't use cybozu-go/well to keep the log format consistent with the reconciler.
For this usage, the default http server is enough, in my opinion.
zoetrope
reviewed
Feb 3, 2023
cmd/moco-controller/cmd/run.go
Outdated
| @@ -136,6 +137,13 @@ func subMain(ns, addr string, port int) error { | |||
| return err | |||
| } | |||
|
|
|||
| if config.pprofAddr != "" { | |||
There was a problem hiding this comment.
I think it would be better to disable pprof even when 0 is specified.
This is because it will be incompatible when using controller-runtime's pprof in the future.
There was a problem hiding this comment.
That's good. Fixed. 6cf0e1c
Signed-off-by: Masayuki Ishii <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pprof server to moco-controller.
The pprof server will start only when
--pprof-addroption is set.Usage: View the trace data
--pprof-addr=:9090option.http://localhost:9091with a Web brower.Signed-off-by: Masayuki Ishii [email protected]