-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
masa213f
commented
Nov 15, 2024
•
edited
Loading
edited
- Update go modules
- Update Ubuntu in development environment
- Update etcd to v3.5.17
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
46af835
to
1c46ea6
Compare
masa213f
commented
Nov 15, 2024
@@ -3,5 +3,5 @@ ZONE=asia-northeast1-c | |||
[email protected] | |||
MACHINE_TYPE=n1-standard-8 | |||
DISK_TYPE=pd-ssd | |||
BOOT_DISK_SIZE=20GB | |||
BOOT_DISK_SIZE=30GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the following error, after updating Ubuntu image.
https://github.com/cybozu-go/etcdpasswd/actions/runs/11852120136/job/33029807091
+ gcloud --quiet --account [email protected] --project neco-test compute instances create etcdpasswd-195-163333 --zone asia-northeast1-c --machine-type n1-standard-8 --image vmx-enabled --boot-disk-type pd-ssd --boot-disk-size 20GB --local-ssd interface=scsi
ERROR: (gcloud.compute.instances.create) Could not fetch resource:
- Invalid value for field 'resource.disks[0].initializeParams.diskSizeGb': '20'. Requested disk size cannot be smaller than the image size (30 GB)
YZ775
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.