Limit the number of components (kubelet, kube-proxy and rivers) that can be updated simultaneously #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent large amounts access to the Internet - Prevent large amounts access to APIServer - Prevent all kubelets from going down Signed-off-by: zoetrope <[email protected]>
Signed-off-by: zoetrope <[email protected]>
…arts. Signed-off-by: zoetrope <[email protected]>
Signed-off-by: zoetrope <[email protected]>
Signed-off-by: zoetrope <[email protected]>
zoetrope
force-pushed
the
concurrent-kubelet-restart
branch
from
73b4b03 to
c6666a2
Compare
zoetrope
changed the title
morimoto-cybozu
requested changes
Jun 1, 2023
server/strategy.go
Outdated
| } | ||
| return ops | ||
| } | ||
|
|
||
| func k8sOps(c *cke.Cluster, nf *NodeFilter, cs *cke.ClusterStatus) (ops []cke.Operator) { | ||
| func separateOperators(nodes []*cke.Node, createOps func(ns []*cke.Node) cke.Operator, maxConcurrentUpdates int) (ops []cke.Operator) { |
There was a problem hiding this comment.
Just a trivial point, but splitOperators() would be more appropriate.
https://www.google.com/search?q=separate+slice+golang
| flgCertsGCInterval = pflag.String("certs-gc-interval", "1h", "tidy interval for expired certificates") | ||
| flgSessionTTL = pflag.String("session-ttl", "60s", "leader session's TTL") | ||
| flgDebugSabakan = pflag.Bool("debug-sabakan", false, "debug sabakan integration") | ||
| flgMaxConcurrentUpdates = pflag.Int("max-concurrent-updates", 10, "the maximum number of components that can be updated simultaneously") |
There was a problem hiding this comment.
Suggested change
| flgMaxConcurrentUpdates = pflag.Int("max-concurrent-updates", 10, "the maximum number of components that can be updated simultaneously") | |
| flgMaxConcurrentUpdates = pflag.Int("max-concurrent-updates", 10, "the maximum number of worker-node components that can be updated simultaneously") |
The description above seems too simple.
It would be nice to add an explanation for how CKE uses this parameter.
How about updating the following section?
https://github.com/cybozu-go/cke/blob/v1.25.3/docs/cluster_overview.md#worker-nodes
CKE deploys each worker-node component concurrently on multiple nodes.
You can control the deployment concurrency by specifying the max-concurrent-updates command-line option.
…w option Signed-off-by: zoetrope <[email protected]>
Signed-off-by: zoetrope <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new cli option
max-concurrent-updates.It can limit the number of components (kubelet, kube-proxy and rivers) that can be updated simultaneously.
This change will solve the following problems:
Signed-off-by: zoetrope [email protected]