Update user-defined resource applying logic #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terassyi
changed the title
yokaze
requested changes
May 16, 2023
zoetrope
reviewed
May 17, 2023
|
@yokaze |
yokaze
reviewed
May 19, 2023
terassyi
force-pushed
the
custom-rank-for-user-defined-resource
branch
from
21bb16f to
c89932a
Compare
Signed-off-by: terasihma <[email protected]>
terassyi
force-pushed
the
custom-rank-for-user-defined-resource
branch
from
4749828 to
e7d93f4
Compare
ysksuzuki
approved these changes
May 25, 2023
Signed-off-by: terasihma <[email protected]>
Signed-off-by: terasihma <[email protected]>
Signed-off-by: terasihma <[email protected]>
Signed-off-by: terasihma <[email protected]>
terassyi
force-pushed
the
custom-rank-for-user-defined-resource
branch
from
e7d93f4 to
02fb62c
Compare
yokaze
approved these changes
May 29, 2023
ysksuzuki
approved these changes
May 29, 2023
zoetrope
approved these changes
May 29, 2023
terassyi
added a commit
that referenced
this pull request
Aug 10, 2023
…efined-resource" This reverts commit 9132754, reversing changes made to d534aed. Signed-off-by: terasihma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features described below.
We can specify the resource application order using the
cke.cybozu.com/rankannotation.Please see docs/user-resources.md for detail.
And When we create or update Deployment or DaemonSet resources, cke checks if the update or creation is completed.
If it is not completed, cke runs the
nopOpthat does nothing to wait.