Fix Hoatzin worldgen thread lock #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the game locking up on the server thread when a Hoatzin attempts to spawn. Closes #1.
This is caused by
isOnGroundbeing overridden, which is a method utilized bywriteNbtduring world generation to fetch its own internal state. The overridden version attempts to read the block below, however the chunk does not exist as it is still generating at this point, so it enters an infinite loop waiting for the thread to unlock and freezes the game.Renaming the overridden method and its usages to something else solves the problem.