forked from apache/orc
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ORC-1430: Use Hadoop 3.3.5 shaded clients
### What changes were proposed in this pull request? Currently, Apache ORC project uses three properties. ``` <hadoop.version>2.7.3</hadoop.version> <min.hadoop.version>2.7.3</min.hadoop.version> <tools.hadoop.version>2.7.3</tools.hadoop.version> ``` This aims the following for Apache ORC 2.0.0. 1. Use Hadoop 3.3.5 shaded clients. 2. Remove `min.hadoop.version` and `tools.hadoop.version` in favor of `hadoop.version` 3. Ban non-shaded clients from now. ``` <bannedDependencies> <excludes> <exclude>org.apache.hadoop:hadoop-common</exclude> <exclude>org.apache.hadoop:hadoop-hdfs-client</exclude> <exclude>org.apache.hadoop:hadoop-mapreduce-client-core</exclude> <exclude>org.apache.hadoop:hadoop-mapreduce-client-jobclient</exclude> </excludes> <searchTransitive>true</searchTransitive> </bannedDependencies> ``` Note that all changes are `pom.xml` files. There is no code change. ### Why are the changes needed? - Hadoop 3's shaded client removes lots of complexity from the downstream clients. - It's stable because Apache Spark community has been using Hadoop 3's shaded client from Apache Spark 3.2.0 (October 13, 2021) via https://issues.apache.org/jira/browse/SPARK-33212. ### How was this patch tested? Pass the CIs. Also, I validated there is no side-effect at Apache Spark side. The following is the change set when Apache Spark upgrades from Apache ORC 1.8.3 (AS-IS) to Apache ORC 2.0.0-SNAPSHOT. ``` -aircompressor/0.21//aircompressor-0.21.jar +aircompressor/0.24//aircompressor-0.24.jar -orc-core/1.8.3/shaded-protobuf/orc-core-1.8.3-shaded-protobuf.jar -orc-mapreduce/1.8.3/shaded-protobuf/orc-mapreduce-1.8.3-shaded-protobuf.jar -orc-shims/1.8.3//orc-shims-1.8.3.jar +orc-core/2.0.0-SNAPSHOT/shaded-protobuf/orc-core-2.0.0-SNAPSHOT-shaded-protobuf.jar +orc-mapreduce/2.0.0-SNAPSHOT/shaded-protobuf/orc-mapreduce-2.0.0-SNAPSHOT-shaded-protobuf.jar +orc-shims/2.0.0-SNAPSHOT//orc-shims-2.0.0-SNAPSHOT.jar ``` Closes apache#1509 from dongjoon-hyun/ORC-1430. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
- Loading branch information
1 parent
1b1366d
commit ca22c15
Showing
10 changed files
with
34 additions
and
447 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.