Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient matching #159

Merged
merged 6 commits into from
Mar 6, 2022
Merged

More efficient matching #159

merged 6 commits into from
Mar 6, 2022

Conversation

sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Feb 17, 2022 •
edited
Loading

  • Avoid the recomputation of pairs in self-matching: this should speed up SfM matching for pairs from retrieval or poses
  • Change the pair format from {name0}_{name1} to {name0}/{name1} to speed up HDF5 hashing

TODO later as it breaks backward compatibility:

  • names_to_pair should be order-invariant, sort the keys
  • Don't write unmatched keypoints -1 in the h5 file

@sarlinpe sarlinpe marked this pull request as ready for review March 1, 2022 23:59
@sarlinpe sarlinpe mentioned this pull request Mar 2, 2022
Closed
@sarlinpe sarlinpe merged commit 653d3e2 into master Mar 6, 2022
@sarlinpe sarlinpe deleted the new-matching branch March 24, 2022 09:54
@sarlinpe sarlinpe mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarlinpe @mihaidusmanu