Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with upstream #79

Merged
merged 25 commits into from
Jan 29, 2025
Merged

sync with upstream #79

merged 25 commits into from
Jan 29, 2025

Conversation

Eldies
Copy link

@Eldies Eldies commented Jan 16, 2025

Summary

syncing

  • plugins/openvino_plugin
  • components/annotation.py
  • components/shift_analyzer.py
  • components/dataset_base.py
  • components/dataset_item_storage.py
  • components/filter.py
  • components/dataset_storage.py
  • components/annotations (extracting from components/operations.py)
  • components/comparator.py (extracting from components/operations.py)
  • components/merge (extracting from components/operations.py)

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 CVAT.ai Corporation
#
# SPDX-License-Identifier: MIT

@Eldies Eldies mentioned this pull request Jan 16, 2025
7 tasks
@Eldies Eldies force-pushed the dl/sync-with-upstream branch from bc757ba to d16d8a3 Compare January 17, 2025 11:22
@@ -85,8 +86,8 @@ def categories(self):
def media_type(self):
return self.parent.media_type()

def ann_types(self):
return []
def ann_types(self) -> Set[AnnotationType]:
Copy link
Collaborator

@zhiltsov-max zhiltsov-max Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's better to annotate it as a Collection so far. Actually, it's ok to keep set for now, just need to revisit this in next prs.

@zhiltsov-max
Copy link
Collaborator

Please check sonar reports, it seems to be correct about errors, e.g.:

return make_index_mask(self.image, index=label_id, ignore_index=ignore_index, dtype=dtype)

There is no ignore_index parameter.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Eldies
Copy link
Author

Eldies commented Jan 29, 2025

fixed sonar issues which seemed serious

@zhiltsov-max zhiltsov-max merged commit e61ebe4 into develop Jan 29, 2025
5 of 6 checks passed
@zhiltsov-max zhiltsov-max deleted the dl/sync-with-upstream branch January 29, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants