-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with upstream #79
Conversation
bc757ba
to
d16d8a3
Compare
src/datumaro/components/dataset.py
Outdated
@@ -85,8 +86,8 @@ def categories(self): | |||
def media_type(self): | |||
return self.parent.media_type() | |||
|
|||
def ann_types(self): | |||
return [] | |||
def ann_types(self) -> Set[AnnotationType]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it's better to annotate it as a Collection
so far. Actually, it's ok to keep set for now, just need to revisit this in next prs.
Co-authored-by: Maxim Zhiltsov <[email protected]>
Please check sonar reports, it seems to be correct about errors, e.g.:
There is no |
|
fixed sonar issues which seemed serious |
Summary
syncing
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.