Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cleanup of previously instance before creating new one #185

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

Shahroz16
Copy link
Contributor

Due to lifecycle differences, multiple instances of the application lifecycle would be added. So we need to unregister old instances of callbacks and also garbage collect any other instance of before.

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@Shahroz16 Shahroz16 changed the base branch from main to fix/android-12-opened-metrics April 4, 2023 11:56
@Shahroz16 Shahroz16 requested a review from a team April 4, 2023 11:57
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #185 (dd14915) into fix/android-12-opened-metrics (a410e6d) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@                         Coverage Diff                         @@
##             fix/android-12-opened-metrics     #185      +/-   ##
===================================================================
+ Coverage                            63.52%   64.13%   +0.60%     
- Complexity                             218      227       +9     
===================================================================
  Files                                   91       91              
  Lines                                 2051     2158     +107     
  Branches                               263      284      +21     
===================================================================
+ Hits                                  1303     1384      +81     
- Misses                                 646      671      +25     
- Partials                               102      103       +1     
Impacted Files Coverage Δ
sdk/src/main/java/io/customer/sdk/CustomerIO.kt 78.02% <100.00%> (+3.86%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Build available to test
Version: shahroz-lifecycle-cleanup-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Shahroz16 Shahroz16 merged commit d52c25b into fix/android-12-opened-metrics Apr 4, 2023
@Shahroz16 Shahroz16 deleted the shahroz/lifecycle-cleanup branch April 4, 2023 12:40
@Shahroz16 Shahroz16 self-assigned this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants