-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added cleanup of previously instance before creating new one #185
fix: added cleanup of previously instance before creating new one #185
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Codecov Report
@@ Coverage Diff @@
## fix/android-12-opened-metrics #185 +/- ##
===================================================================
+ Coverage 63.52% 64.13% +0.60%
- Complexity 218 227 +9
===================================================================
Files 91 91
Lines 2051 2158 +107
Branches 263 284 +21
===================================================================
+ Hits 1303 1384 +81
- Misses 646 671 +25
- Partials 102 103 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Build available to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Due to lifecycle differences, multiple instances of the
application
lifecycle would be added. So we need to unregister old instances of callbacks and also garbage collect any other instance of before.Complete each step to get your pull request merged in. Learn more about the workflow this project uses.