Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button-card broken in HA 2023.4 (beta) Dont update if you use button-card #669

Closed
2 tasks
Mariusthvdb opened this issue Mar 30, 2023 · 19 comments
Closed
2 tasks
Labels

Comments

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Mar 30, 2023

Checklist

  • I updated the card to the latest version available
  • I cleared the cache of my browser

Describe the bug
A clear and concise description of what the bug is.

2023.4 beta launched today, and the many changes in the frontend cause button-card to no longer be functional.

according to Frontend dev this might be an issue:

  • custom-card-helpers is broken, it walks through DOM elements and something changed in those elements

Version of the carde
Version:

To Reproduce
This is the configuration I used:

Screenshots
If applicable, add screenshots to help explain your problem.

Scherm­afbeelding 2023-03-30 om 09 20 41

Expected behavior
A clear and concise description of what you expected to happen.

Seems obvious... ourDashboard to be functional with the best card around

Desktop (please complete the following information):
Any

Smartphone (please complete the following information):
Any

Additional context
Add any other context about the problem here.

This seems to be a generic issue with the card, I didnt have a chance to find a specific detail yet, had to roll back to 2023.3.6 in order to have a functional frontend....

in the #beta on Discord it was mentioned that the same also applies to Decluttering-card and Apex-charts-card.

Hope you're still around RR, and can find the time to fix these so very fundamental cards.

@Mariusthvdb Mariusthvdb added the bug Something isn't working label Mar 30, 2023
@Mariusthvdb Mariusthvdb changed the title Button-card broken in 2023.4 (beta) Button-card broken in HA 2023.4 (beta) Dont update if you use button-card Mar 30, 2023
@tomlut
Copy link

tomlut commented Mar 30, 2023

@Mariusthvdb
Copy link
Contributor Author

yes, and to make it directly available like @kulmegil found out in https://community.home-assistant.io/t/lovelace-button-card/65981/6839

replace:

querySelector(“app-drawer-layout partial-panel-resolver”)

with:

querySelector("app-drawer-layout partial-panel-resolver, mwc-drawer partial-panel-resolver")

@guevara777
Copy link

I forked this repository, made the changes and tried to add it as a "custom repository to hacs.

That doesn't work
image

Any ideas how to get the card back to work again?

I need help, please.

@kulmegil
Copy link

kulmegil commented Apr 1, 2023

I'm not smart enough to actually provide more insightful help as I lack the experience, but here is the link for requirements:
https://hacs.xyz/docs/publish/plugin

I'm pretty sure hacs needs to locate a valid build .js file
(either attached to latest release or in repo root or /dist folder)

Not sure how crash with button-card already being a part of default repos list.
(is unique repo name required?)

@Mariusthvdb
Copy link
Contributor Author

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

@guevara777
Copy link

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

This is wonderful news. I´ve used the button-card very often in my dashboard and it looks like shi... right now. Thank you very much! 💯

@guevara777
Copy link

I have it on good authority, we have to wait until Monday, and some mysterious dev will have a look and release a fix....so have some patience, (and until that time, edit the resource manually)

I´ve edited the resource here:
image

I´ve replaced
image

with
image

and restarted ha. Sadly it still looks the same.

What did i do wrong?

@Mariusthvdb
Copy link
Contributor Author

you probably still have it in the HACS folder? and use the HACS resource techniques, which can not be fooled easily. ;-)

make a new resource, add it in another folder in www, and point the resources file to that new resource. You can do that in Yaml mode, or via the UI

@guevara777
Copy link

guevara777 commented Apr 1, 2023

you probably still have it in the HACS folder? and use the HACS resource techniques, which can not be fooled easily. ;-)

make a new resource, add it in another folder in www, and point the resources file to that new resource. You can do that in Yaml mode, or via the UI

you're right. It is still in the Hacs folder. I´ll try that. Thank you ❤️

Edit: Tried it and failed. Maybe i´m not experienced enough. I'll just wait and be grateful that someone is working on it ❤️

@firstof9
Copy link

firstof9 commented Apr 1, 2023

delete the .gz files first THEN edit the .js file.

Note: You just needed to replace "app-drawer-layout partial-panel-resolver" into "app-drawer-layout, mwc-drawer partial-panel-resolver" and it should work with both beta and previous versions as well.

@RomRider
Copy link
Collaborator

RomRider commented Apr 1, 2023

I'll fix that Monday, folks (as well as the 2 others)

@Mariusthvdb
Copy link
Contributor Author

RomRider, you're the best! Do notice https://discord.com/channels/330944238910963714/427516175237382144/1091751687221424159 though....

OK, I know you will all hate me for doing this, but believe me it is better to do it now then later 😬
We will rename mwc-drawer to ha-drawer during the beta (hopefully next beta)
This means all custom cards that where updated to mwc-drawer should now be updated again to ha-drawer

github-actions bot pushed a commit that referenced this issue Apr 2, 2023
## [3.5.0-dev.2](v3.5.0-dev.1...v3.5.0-dev.2) (2023-04-02)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [#669](#669) [#671](#671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [#672](#672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [#652](#652)

### Documentation

* minor quotes correction ([#437](#437)) ([9b5f728](9b5f728))
* minor quotes correction ([#438](#438)) ([07ae7a1](07ae7a1))
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

🎉 This issue has been resolved in version 3.5.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Apr 2, 2023
## [3.5.0](v3.4.2...v3.5.0) (2023-04-02)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [#426](#426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [#669](#669) [#671](#671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [#672](#672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [#652](#652)

### Documentation

* minor quotes correction ([#437](#437)) ([9b5f728](9b5f728))
* minor quotes correction ([#438](#438)) ([07ae7a1](07ae7a1))
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@RomRider
Copy link
Collaborator

RomRider commented Apr 2, 2023

Note: I've updated it directly to use ha-drawer

@Mariusthvdb
Copy link
Contributor Author

Great. Much appreciated! Beyond joy here.

@modem158
Copy link

Anyone else still having this issue? I've updated to 3.5.0 and I'm using the cards with Lovelace Minimalist. Cleared cache and all that jazz to no avail.

@kulmegil
Copy link

kulmegil commented Apr 11, 2023

@modem158
Can you confirm the version displayed in your browser devtools console when HA is loading is indeed 3.5.0?
Untitled5

@modem158
Copy link

@kulmegil looks like it's me. I connect to HA at work through Nabu Casa and for some reason that browser refused to show my cards all day (even with a cache clear and restart). It's working fine on my phone and at home. Strange behavior that I couldn't clear my cache at work and have it reload properly. I'll play some more tomorrow. Thanks for your reply.

github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants