Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snippet csv support #2841

Open
pokey opened this issue Feb 9, 2025 · 1 comment · May be fixed by #2842
Open

Remove snippet csv support #2841

pokey opened this issue Feb 9, 2025 · 1 comment · May be fixed by #2842
Assignees

Comments

@pokey
Copy link
Member

pokey commented Feb 9, 2025

Is there a reason we're keeping the snippet csv support around? From what I can tell everything else has been removed. See eg

"experimental/wrapper_snippets.csv": {
"wrapper_snippet": {
"else": "ifElseStatement.alternative",
"funk": "functionDeclaration.body",
"if else": "ifElseStatement.consequence",
"if": "ifStatement.consequence",
"try": "tryCatchStatement.body",
"link": "link.text"
}
},
"experimental/insertion_snippets.csv": {
"insertion_snippet_no_phrase": {
"if": "ifStatement",
"if else": "ifElseStatement",
"try": "tryCatchStatement"
}
},
"experimental/insertion_snippets_single_phrase.csv": {
"insertion_snippet_single_phrase": {
"funk": "functionDeclaration.name",
"link": "link.text"
}

Without it being removed, the files keep coming back after I deleted them

pokey added a commit to pokey/pokey_talon that referenced this issue Feb 9, 2025
Until
cursorless-dev/cursorless#2841
is tackled, they keep coming back with the
defaults, which is annoying.

This reverts commit dd52ed2.
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Feb 10, 2025

We still need to read from these lists for the migration, but maybe we can remove them from the spoken form json?

edit: I tried it and removing these lines throws an error that breaks Cursorless. See pr #2842

@AndreasArvidsson AndreasArvidsson self-assigned this Feb 10, 2025
@AndreasArvidsson AndreasArvidsson linked a pull request Feb 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants