Skip to content

Commit

Permalink
Fix cli group (#419)
Browse files Browse the repository at this point in the history
* fix cli group

* fix app cli group

* fix all

* fixed

* linter
  • Loading branch information
alexviquez authored Aug 28, 2023
1 parent 08f59f3 commit 793502c
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 11 deletions.
4 changes: 2 additions & 2 deletions speid/commands/spei.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import click
from mongoengine import DoesNotExist

from speid import app
from speid.helpers.callback_helper import set_status_transaction
from speid.models import Event, Transaction
from speid.types import Estado, EventType


@click.group('speid')
@app.cli.group('speid')
def speid_group():
"""Perform speid actions."""
pass


@speid_group.command('callback-spei-transaction')
Expand Down
16 changes: 7 additions & 9 deletions tests/commands/test_spei.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import pytest
from click.testing import CliRunner

from speid.commands.spei import speid_group
from speid.models import Transaction
Expand Down Expand Up @@ -27,11 +26,10 @@ def transaction():
transaction.delete()


def test_callback_spei_transaction(mock_callback_queue, transaction):
def test_callback_spei_transaction(runner, mock_callback_queue, transaction):
id_trx = transaction.id
assert transaction.estado is Estado.created

runner = CliRunner()
runner.invoke(
speid_group, ['callback-spei-transaction', str(id_trx), 'succeeded']
)
Expand All @@ -42,11 +40,12 @@ def test_callback_spei_transaction(mock_callback_queue, transaction):
assert transaction.events[-1].metadata == 'Reversed by SPEID command'


def test_callback_spei_failed_transaction(mock_callback_queue, transaction):
def test_callback_spei_failed_transaction(
runner, mock_callback_queue, transaction
):
id_trx = transaction.id
assert transaction.estado is Estado.created

runner = CliRunner()
runner.invoke(
speid_group, ['callback-spei-transaction', str(id_trx), 'failed']
)
Expand All @@ -57,11 +56,12 @@ def test_callback_spei_failed_transaction(mock_callback_queue, transaction):
assert transaction.events[-1].metadata == 'Reversed by SPEID command'


def test_callback_spei_invalid_transaction(mock_callback_queue, transaction):
def test_callback_spei_invalid_transaction(
runner, mock_callback_queue, transaction
):
id_trx = transaction.id
assert transaction.estado is Estado.created

runner = CliRunner()
result = runner.invoke(
speid_group, ['callback-spei-transaction', str(id_trx), 'invalid']
)
Expand All @@ -76,7 +76,6 @@ def test_re_execute_transactions(runner, transaction, physical_account):
id_trx = transaction.id
assert transaction.estado is Estado.created

runner = CliRunner()
runner.invoke(
speid_group, ['re-execute-transactions', transaction.speid_id]
)
Expand All @@ -93,7 +92,6 @@ def test_re_execute_transaction_not_found(
id_trx = transaction.id
assert transaction.estado is Estado.created

runner = CliRunner()
result = runner.invoke(
speid_group, ['re-execute-transactions', 'invalid_speid_id']
)
Expand Down
8 changes: 8 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,22 @@

import pytest
from celery import Celery
from flask.testing import FlaskCliRunner

from speid import app
from speid.models import Transaction
from speid.types import TipoTransaccion

SEND_TRANSACTION_TASK = os.environ['SEND_TRANSACTION_TASK']
SEND_STATUS_TRANSACTION_TASK = os.environ['SEND_STATUS_TRANSACTION_TASK']


@pytest.fixture
def runner():
runner = FlaskCliRunner(app)
return runner


@pytest.fixture
def mock_callback_queue():
with patch.object(Celery, 'send_task', return_value=None):
Expand Down

0 comments on commit 793502c

Please sign in to comment.