protobuf: enable protobuf standard required mechanism
#2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://google.aip.dev/203. Currently, there is support for an option `(cue.opt).required`. This is fine, but requires importing the `cue.proto`, and exposes cue to the public facing API. With this approach, the built-in field behavior mechanism can be used, which is the standard way to declare a required field in proto. Signed-off-by: John Howard <[email protected]>
|
Apologies that we didn't respond here sooner. Is there a particular reason you closed this PR? Personally this seems like a good change to incorporate, so if you want to re-open the PR I can import it to Gerrit and get it merged. I can always do that even if you don't reopen the PR, but ideally I'd like your permission to do so :) |
|
Feel free to pick it up. We ended up moving off of Cue so there wasn't a
need to pursue this further
…On Fri, Nov 17, 2023, 5:53 AM Daniel Martí ***@***.***> wrote:
Apologies that we didn't respond here sooner. Is there a particular reason
you closed this PR?
Personally this seems like a good change to incorporate, so if you want to
re-open the PR I can import it to Gerrit and get it merged. I can always do
that even if you don't reopen the PR, but ideally I'd like your permission
to do so :)
—
Reply to this email directly, view it on GitHub
<#2622 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXPCZCHUHTAPXUNFX63YE5T6VAVCNFSM6AAAAAA5LT2DQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGQ3TEMZZGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Thanks! Imported to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1172314. |
cueckoo
pushed a commit
that referenced
this pull request
Nov 20, 2023
See https://google.aip.dev/203. Currently, there is support for the option `(cue.opt).required`. This is fine, but requires importing the `cue.proto`, and exposes cue to the public facing API. With this approach, the existing field behavior mechanism can be used, which is the standard way to declare a required field in proto, like: RecognitionAudio audio = 2 [(google.api.field_behavior) = REQUIRED]; Closes #2622 as merged as of commit 6974630. Signed-off-by: John Howard <[email protected]> Change-Id: Ia8079a8b148c9abe9b6fe26d090c86cb4489359a Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1172314 Unity-Result: CUE porcuepine <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Reviewed-by: Paul Jolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://google.aip.dev/203. Currently, there is support for an option
(cue.opt).required. This is fine, but requires importing thecue.proto, and exposes cue to the public facing API.With this approach, the built-in field behavior mechanism can be used, which is the standard way to declare a required field in proto.