Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix error in dynamic fields example #2621

Closed

Conversation

SteVwonder
Copy link
Contributor

Since a: "foo" is provided in the example, the result of (a): "baz"
is foo: "baz" not bar: "baz".

Also add a missing quote.

Closes: #2592

@SteVwonder SteVwonder requested a review from cueckoo as a code owner September 28, 2023 17:01
Since `a: "foo"` is provided in the example, the result of `(a): "baz"`
is `foo: "baz"` not `bar: "baz"`.

Also add a missing quote.

Closes: cue-lang#2592
Signed-off-by: Stephen Herbein <[email protected]>
@SteVwonder SteVwonder force-pushed the fix-dynamic-fields-example branch from adceef8 to 813f70a Compare September 28, 2023 17:03
Copy link
Member

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@mvdan
Copy link
Member

mvdan commented Oct 25, 2023

Imported as https://review.gerrithub.io/c/cue-lang/cue/+/1171216; merging on green.

@mvdan mvdan self-assigned this Oct 25, 2023
@myitcv
Copy link
Member

myitcv commented Oct 26, 2023

Thanks for spotting this. Also nothing that the new alpha.cuelang.org setup will make spotting things like this easier, because code blocks validate the formatting and correctness of CUE and other languages.

@cueckoo cueckoo closed this in 200a8ec Oct 26, 2023
@SteVwonder SteVwonder deleted the fix-dynamic-fields-example branch October 26, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Dynamic fields example has errors
3 participants