cue/fmt: Lists are indented too much

[uhthomas]

What version of CUE are you using (cue version)?

$ cue version
0.4.3-1

Does this issue reproduce with the latest stable release?

Yes.

What did you do?

import "list"

#List: items: list.Concat([
    a,

    b
])

What did you expect to see?

import "list"

#List: items: list.Concat([
    a,

    b
])

What did you see instead?

import "list"

#List: items: list.Concat([
        a,

    b
])

[uhthomas]

FWIW, this is fine:

import "list"

items: list.Concat([
    a,

    b
])

Looks like a problem with shorthand notation and depth calculation. The formatter should understand that just because it's of depth: 2 does not mean that's how much it should be indented. Clearly the logic for this already exists as successive items are indented correctly.

[mvdan]

Thank you, this does look like a formatting bug.

[uhthomas]

Looks like it's related to the length of the line.

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: list.Concat([
                                                ["a"],

        ["b"],
])

[Nemo157]

It seems to only trigger when the list is not the top-level value, i.e. this is fine:

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: [
        ["a"],

        ["b"],
]

but these fail:

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: _ | [
                                                ["a"],

        ["b"],
]

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: *[
                                                ["a"],

        ["b"],
]

if the subsequent lines don't change indentation then it continues using the incorrect indentation for them:

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: *[
                                                ["a"],
                                                ["b"],
]