Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update latest PHP version to last non-EOL version #228

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

olleolleolle
Copy link
Contributor

🤔 What's changed?

Went from 8.1 to 8.2.

⚡️ What's your motivation?

8.1 is EOL.
8.2 is still supported.

When reading https://phpunit.de/announcements/phpunit-11.html I saw that since Feb 2 2024, 8.2 is the oldest still-supported PHP version.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

When reading https://phpunit.de/announcements/phpunit-11.html I saw that since Feb 2 2024, 8.2 is the oldest still-supported PHP version.
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@mpkorstanje mpkorstanje merged commit 252e9ca into main Feb 29, 2024
1 check passed
@mpkorstanje mpkorstanje deleted the ci-use-php-82 branch February 29, 2024 11:36
@mpkorstanje
Copy link
Contributor

I suppose it would also be prudent to update the minimum version in composer aswell. Could you do that and include an item in the release notes under the ### Changed header?

https://github.com/cucumber/gherkin/blob/main/php/composer.json#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants