Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on oldest supported Perl too #145

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Test on oldest supported Perl too #145

merged 1 commit into from
Aug 11, 2023

Conversation

ehuelsmann
Copy link
Contributor

🤔 What's changed?

Since we support older Perls, test with the oldest supported Perl too.

⚡️ What's your motivation?

Captures issues before cpantesters will (although it's good to have those as backup).

🏷️ What kind of change is this?

🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I hope 1 more matrix variant isn't too much of a burden.

📋 Checklist:

@ehuelsmann ehuelsmann force-pushed the perl-matrix branch 4 times, most recently from fd89427 to dd11ac8 Compare August 11, 2023 09:12
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do keep the size of test matrix at 2 though. Otherwise the project will take ages to build.

There are some matrices for other languages in other projects that are larger, but those are not aspirational.

@mpkorstanje mpkorstanje merged commit 6b87fb3 into main Aug 11, 2023
@mpkorstanje mpkorstanje deleted the perl-matrix branch August 11, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants