Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

cucumber-js now supports BeforeStep and AfterStep hooks #653

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

MarekVigas
Copy link
Contributor

@MarekVigas MarekVigas commented Aug 13, 2021

Description

BeforeStep and AfterStep hooks were added in cucumber-js version 7.0.0. This feature was added in this merge request and documentation was not updated. This PR fixes docs about javascript and cucumber-js.

Motivation & context

Documentation is misleading and outdated.

Type of change

  • Refactoring/debt update docs

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aurelien-reeves
Copy link
Contributor

@MarekVigas Thanks for your PR, and sorry to have missed it until now 🙇‍♂️

Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BeforeStep and AfterStep in JavaScript do not actually have a scenario parameter. You can see their signature here: https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/api_reference.md#afterstepoptions-fn

@MarekVigas
Copy link
Contributor Author

@aurelien-reeves thanks for the review 😊

You have a valid point and I fixed it according to the signatures.

@aurelien-reeves
Copy link
Contributor

Great, thanks

@aurelien-reeves aurelien-reeves merged commit 559be21 into cucumber:main Sep 7, 2021
@aslakhellesoy
Copy link
Contributor

Hi @MarekVigas,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@MarekVigas MarekVigas deleted the js-before-after-steps branch September 7, 2021 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants