Add Rails 7 support #526
Add Rails 7 support #526
Conversation
Three test were failing. Two because Rails 7 uses modern HTML control (input type "datetime-local") for datepickers. It was necessary to change capybara helper based on Rails version. The other issue is that Destroy link is not present on index action anymore. The test description changed to navigate the corresponding page based on Rails version.
|
Hi, I can see that specs are failing against Ruby 2.5 but it looks like an issue not related to this change |
|
Yes, the issue is not related to rails 7 changes. Made another PR that doesn't change the code and ruby 2.5 fails too. I'm looking for solutions / explanations. Maybe drop ruby 2.5 support is an alternative. |
maybe it requires an older version of webdrivers, selenium-webdriver, or childprocess. I wasn't able to replicate on my development machine, so I'm not sure |
Test fail on ruby 2.5. Bundler fails to fetch a gem. Seems an environment problem that can be solved by update rubygems.
|
From what I can tell is an issue of the environment (ruby + bundler + rubygems) because bundler fails fetching. |
|
Yes, I found an issue of webdrivers compatibility on another gem I support. See here: https://github.com/site-prism/site_prism/blob/main/gemfiles/Gemfile.low_spec#L9 |
cucumber-rails.gemspec
Outdated
| @@ -25,7 +25,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency('cucumber', ['>= 3.2', '< 8']) # Support cucumber in the 3.x <-> 7.x revision range | |||
| s.add_runtime_dependency('mime-types', ['~> 3.3']) # Only support the latest major (3+ years old) | |||
| s.add_runtime_dependency('nokogiri', '~> 1.10') # Only support the latest major (3+ years old) | |||
| s.add_runtime_dependency('railties', ['>= 5.0', '< 7']) # We support any version of Rails in the 5.x and 6.x series | |||
| s.add_runtime_dependency('railties', ['>= 5.0', '< 7.1']) # We support any version of Rails in the 5.x, 6.x and 7.0.x series | |||
There was a problem hiding this comment.
This should be permissible for all 7.x series gems.
features/emulate_javascript.feature
Outdated
| end | ||
| end | ||
|
|
||
| When('I am on destroy {string} page') do |name| |
There was a problem hiding this comment.
can we change this to be a Given step
|
@luke-hill I asked for review and then saw your approval, sorry. |
|
Thanks! |
|
Is this version released? |
|
We're currently merging in lots of items. A release will be cut when appropriate. |
|
Hi, thanks for the hard work on getting the gem RoR7-ready! ❤️ Any ETA on the new version being cut and released? 😬 Thanks a heap 🙇 |
|
Honestly we don't sorry. I will commit to it being out in the next month, I appreciate that's not a great answer. Just a few things going on atm. |
|
https://rubygems.org/gems/cucumber-rails/versions/2.5.0 is now released. |
|
Thanks a lot @luke-hill Just in time for the sakura 桜🌸 |
Summary
Fixes #523
The PR was built based on issue comments.
Three tests were failing. Two because Rails 7 uses modern HTML control (input type "datetime-local") for datepickers. Capybara helper acts differently based on Rails version
The other test was failing because Destroy link is not present on index action anymore. The test changed to navigate the corresponding page based on Rails version.