Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Do not invoke after test method if test failed to start #2585

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

mpkorstanje
Copy link
Contributor

🤔 What's changed?

Fixes: #2584

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #2585 (45bf7f5) into main (4f0cc30) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2585   +/-   ##
=========================================
  Coverage     84.68%   84.69%           
- Complexity     2671     2672    +1     
=========================================
  Files           311      311           
  Lines          9378     9380    +2     
  Branches        901      902    +1     
=========================================
+ Hits           7942     7944    +2     
  Misses         1109     1109           
  Partials        327      327           
Impacted Files Coverage Δ
...in/java/io/cucumber/spring/TestContextAdaptor.java 93.05% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0cc30...45bf7f5. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the 2584-fix-failure-on-test-instance-creation branch from e8d2908 to cd693c8 Compare July 20, 2022 20:49
@mpkorstanje mpkorstanje marked this pull request as ready for review July 20, 2022 20:50
@mpkorstanje mpkorstanje force-pushed the 2584-fix-failure-on-test-instance-creation branch from cd693c8 to 45bf7f5 Compare July 27, 2022 01:21
@mpkorstanje mpkorstanje merged commit 91deb2a into main Jul 27, 2022
@mpkorstanje mpkorstanje deleted the 2584-fix-failure-on-test-instance-creation branch July 27, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misleading message when SpringFactory doesn't start correctly
1 participant