[Java] Process glue classes distinctly #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2582 +/- ##
=========================================
Coverage 84.61% 84.62%
Complexity 2661 2661
=========================================
Files 310 310
Lines 9348 9352 +4
Branches 899 899
=========================================
+ Hits 7910 7914 +4
Misses 1109 1109
Partials 329 329
Continue to review full report at Codecov.
|
Users may provide glue paths where one is a strict subset of hte other. For example: ``` com.example com.example.app ``` Cucumber would scan both packages (and sub packages), and for each process the classes it discovered. This would result in the classes from the `app` package being processed twice. Fixes: #2581
mpkorstanje
force-pushed
the
2581-process-glue-classes-distinctly
branch
from
4bf1dc5 to
54ed086
Compare
gaeljw
added a commit
to cucumber/cucumber-jvm-scala
that referenced
this pull request
Jul 28, 2022
See cucumber/cucumber-jvm#2582 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may provide glue paths where one is a strict subset of hte other.
For example:
Cucumber would scan both packages (and sub packages), and for each process the
classes it discovered. This would result in the classes from the
apppackagebeing processed twice.
Fixes: #2581
🏷️ What kind of change is this?
📋 Checklist: