Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guice] Automatically detect InjectorSource #2432

Conversation

PostelnicuGeorge
Copy link
Contributor

Is your pull request related to a problem? Please describe.
Implementation of #2278

@PostelnicuGeorge PostelnicuGeorge marked this pull request as draft December 4, 2021 09:06
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #2432 (8e8a287) into main (e8fbb0f) will increase coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2432      +/-   ##
============================================
+ Coverage     83.67%   83.70%   +0.03%     
- Complexity     2648     2666      +18     
============================================
  Files           317      319       +2     
  Lines          9349     9392      +43     
  Branches        907      909       +2     
============================================
+ Hits           7823     7862      +39     
- Misses         1192     1193       +1     
- Partials        334      337       +3     
Impacted Files Coverage Δ
.../java/io/cucumber/guice/InjectorSourceFactory.java 86.95% <83.33%> (-13.05%) ⬇️
.../src/main/java/io/cucumber/guice/GuiceFactory.java 92.85% <90.00%> (+1.94%) ⬆️
.../src/main/java/io/cucumber/guice/GuiceBackend.java 100.00% <100.00%> (ø)
...io/cucumber/guice/GuiceBackendProviderService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8fbb0f...8e8a287. Read the comment docs.

@PostelnicuGeorge
Copy link
Contributor Author

I have finished the tests and implementation, can I get advice on how to fix the java.class.externalClassExposedInAPI: interface io.cucumber.core.backend.Backend: A class from supplementary archives is used in a public capacity in the API. [io.cucumber:cucumber-core:jar:7.1.0-SNAPSHOT] errors from Test (Semver check) build step?

@PostelnicuGeorge PostelnicuGeorge marked this pull request as ready for review December 4, 2021 18:14
@mpkorstanje mpkorstanje self-requested a review December 11, 2021 12:42
@mpkorstanje mpkorstanje changed the title Automatically detect Guice InjectorSource #2278 [Guice] Automatically detect InjectorSource #2278 Jan 1, 2022
@mpkorstanje mpkorstanje changed the title [Guice] Automatically detect InjectorSource #2278 [Guice] Automatically detect InjectorSource Jan 1, 2022
@mpkorstanje mpkorstanje added this to the v7.x.x milestone Jan 1, 2022
@mpkorstanje mpkorstanje merged commit d5ce486 into cucumber:main Jan 1, 2022
@mpkorstanje
Copy link
Contributor

Cheers again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants