Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-meta/ruby: Create messages rather than plain hashes #1772

Merged
merged 6 commits into from
Oct 11, 2021

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Oct 1, 2021

Summary

The ruby implementation of create-meta did not create proper messages but plain ruby hashes. That is responsible for generating ndjson with snake_case key for protocol_version.

Details

I have converted the meta hashes into messages DTOs

Motivation and Context

While working on reactivating the CCK for cucumber-ruby, it appears that meta.protocol_version was not camelized in the resulting ndjson

How Has This Been Tested?

I have used the existing spec, and added one to make sure the CI was also properly filled

Types of changes

  • Bug fix (non-breaking change which fixes an issue).

Checklist:

  • The change has been ported to Ruby.
  • I've added tests for my code.
  • I have updated the CHANGELOG accordingly.

@aurelien-reeves aurelien-reeves enabled auto-merge (squash) October 11, 2021 14:14
@aurelien-reeves aurelien-reeves merged commit bb8f3a3 into main Oct 11, 2021
@aurelien-reeves aurelien-reeves deleted the create-meta/ruby/create-messages-over-hashes branch October 11, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant