create-meta/ruby: Create messages rather than plain hashes #1772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ruby implementation of create-meta did not create proper messages but plain ruby hashes. That is responsible for generating ndjson with snake_case key for
protocol_version
.Details
I have converted the meta hashes into messages DTOs
Motivation and Context
While working on reactivating the CCK for cucumber-ruby, it appears that meta.protocol_version was not camelized in the resulting ndjson
How Has This Been Tested?
I have used the existing spec, and added one to make sure the CI was also properly filled
Types of changes
Checklist: