Add java, js and ruby GHA workflows #4
Conversation
|
@aslakhellesoy FYI the acceptance tests still need to be migrated |
|
Yes, let’s use the same approach we use in tag-expressions and cucumber-expressions where we have native tests that read the acceptance test data files. |
|
Ruby and JavaScript acceptance tests migrated from make to rspec/mocha. @aslakhellesoy @mpkorstanje Need help with Java 😭 |
javascript/src/createMeta.ts
Outdated
| import defaultCiDict from './ciDict.json' | ||
| import evaluateVariableExpression from './evaluateVariableExpression' | ||
| import { CiDict, CiSystem, Env } from './types' | ||
|
|
||
| interface gitHash { |
There was a problem hiding this comment.
Use a capital letter for types. Prefer type over interface when there are no methods. gitHash sounds strange to me. How about GitInfo?
There was a problem hiding this comment.
(Aside: Perhaps a Git "tree-ish"? But, the remote is not a part of that, though.)
There was a problem hiding this comment.
Indeed it looks a little bit like a tree-ish
GitInfo seems more generic, and maybe more common in a context like the one in CreateMeta.
(I was not convince with gitHash myself :p)
|
@aurelien-reeves look at how it's done in https://github.com/cucumber/cucumber-expressions/blob/main/java/src/test/java/io/cucumber/cucumberexpressions/CucumberExpressionParserTest.java - let me know if you want to pair. |
|
@aslakhellesoy I have been able to make some progress with the java acceptance testing But there is still some work to do with those, I am far from having finished those. |
Description
Add workflows to the CI