Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Minimum version bump #228

Merged
merged 11 commits into from
Nov 16, 2023
Merged

[Ruby] Minimum version bump #228

merged 11 commits into from
Nov 16, 2023

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Bump minimum versions of gems/ruby
Remove lots of crud that supported old rubies

⚡️ What's your motivation?

Tidy up codebase

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d41178f) 91.17% compared to head (e4040ce) 91.17%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files           2        2           
  Lines          34       34           
=======================================
  Hits           31       31           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luke-hill luke-hill merged commit 2756b0a into main Nov 16, 2023
@luke-hill luke-hill deleted the feature/ruby+bump branch November 16, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants