split HomeBlockProps into TitleBlockProps, HomeBlockProps and ProjectCarouselBlockProps
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CarouselBlockProps
AdiChops
reviewed
Dec 15, 2023
There was a problem hiding this comment.
do we need 3 interfaces? ProjectCarouselBlockProps is understandable since the slider has different enough content, but do we need both TitleBlockProps and HomeBlockProps? It seems like the only difference is the style attribute and the border attribute in image, which already is optional. I am good with having it either way, it just seems like its an extra interface for a very small difference, so theres a lot of code duplication with the definition of the interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No visible changes on the front end.
Just split an overgeneralized
HomeBlockPropsinterface into 3.