Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove older bun version pins from workflows once bun v1.1.46 is out #363

Closed
lgarron opened this issue Jan 20, 2025 · 3 comments
Closed
Labels
🐞 bug Something isn't working

Comments

@lgarron
Copy link
Member

lgarron commented Jan 20, 2025

There's a really silly issue where making a directory with -p or "recursive": true results in an error:

await mkdir("./.temp", { recursive: true });

EEXIST: file already exists, mkdir './.temp'
    path: "./.temp",
 syscall: "mkdir",
   errno: -17,
    code: "EEXIST"

I've run into this in a few project already, and I don't know if the issue is with bun, with GitHub, or with Linux. It seems to be at least partially environment-specific, as I can't reproduce on macOS (notwithstanding the many, many times I run into similar errors due to a different issue).

@lgarron lgarron added the 🐞 bug Something isn't working label Jan 20, 2025
@lgarron lgarron changed the title Figure out how to Fix CI Remove older bun version pins from workflows once bun v1.1.46 is out Jan 20, 2025
lgarron added a commit that referenced this issue Jan 20, 2025
@lgarron
Copy link
Member Author

lgarron commented Jan 21, 2025

I'm a little confused. https://bun.sh/blog/bun-v1.1.45#fixed-fs-mkdir-recursive-regression implies that this was fixed in bun 1.45.

But our CI was failing on this with 1.1.45+196621f25: oven-sh/bun@196621f25

@lgarron
Copy link
Member Author

lgarron commented Jan 21, 2025

I'm a little confused. https://bun.sh/blog/bun-v1.1.45#fixed-fs-mkdir-recursive-regression implies that this was fixed in bun 1.45.

But our CI was failing on this with 1.1.45+196621f25: oven-sh/bun@196621f25

Ah. The changelog is a lie:

oven-sh/bun#16536 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant