Bump the number of supported moves for the simultaneous move indexer …

…up to 256.

Closes #325

This also fixes the calculation to prevent URLs like https://alpha.twizzle.net/edit/?alg=%28R+L%27%29+%28.%2910000000 from failing to load.

src/cubing/notation/CountMoves.ts

@@ -66,6 +66,50 @@ class CountMoves extends TraversalUp<number> {
   }
 }
 
+// TODO
+class CountLeavesInExpansionForSimultaneousMoveIndexer extends TraversalUp<number> {
+  public traverseAlg(alg: Alg): number {
+    let r = 0;
+    for (const algNode of alg.childAlgNodes()) {
+      r += this.traverseAlgNode(algNode);
+    }
+    return r;
+  }
+
+  public traverseGrouping(grouping: Grouping): number {
+    const alg: Alg = grouping.alg;
+    return this.traverseAlg(alg) * Math.abs(grouping.amount);
+  }
+
+  public traverseMove(move: Move): number {
+    return 1;
+  }
+
+  public traverseCommutator(commutator: Commutator): number {
+    return (
+      2 * (this.traverseAlg(commutator.A) + this.traverseAlg(commutator.B))
+    );
+  }
+
+  public traverseConjugate(conjugate: Conjugate): number {
+    return 2 * this.traverseAlg(conjugate.A) + this.traverseAlg(conjugate.B);
+  }
+
+  // TODO: Remove spaces between repeated pauses (in traverseSequence)
+  public traversePause(_pause: Pause): number {
+    return 1;
+  }
+
+  public traverseNewline(_newLine: Newline): number {
+    return 1;
+  }
+
+  // TODO: Enforce being followed by a newline (or the end of the alg)?
+  public traverseLineComment(_comment: LineComment): number {
+    return 1;
+  }
+}
+
 function isCharUppercase(c: string): boolean {
   return "A" <= c && c <= "Z";
 }
@@ -120,6 +164,11 @@ export const countRangeBlockMovesPG = functionFromTraversal(CountMoves, [
   rangeBlockTurnMetric,
 ]);
 
+export const countLeavesInExpansionForSimultaneousMoveIndexer =
+  functionFromTraversal(CountLeavesInExpansionForSimultaneousMoveIndexer, [
+    baseMetric,
+  ]);
+
 /**
  * Only implemented so far:
  *

src/cubing/notation/cubing-private/index.ts

@@ -0,0 +1 @@
+export { countLeavesInExpansionForSimultaneousMoveIndexer } from "../CountMoves";

src/cubing/twisty/model/props/puzzle/state/IndexerConstructorProp.ts

@@ -1,7 +1,7 @@
 import type { AlgIndexer } from "../../../..";
 import type { Alg } from "../../../../../alg";
 import type { KPuzzle } from "../../../../../kpuzzle";
-import { experimentalCountMoves } from "../../../../../notation";
+import { countLeavesInExpansionForSimultaneousMoveIndexer } from "../../../../../notation/CountMoves";
 import { SimpleAlgIndexer } from "../../../../controllers/indexer/SimpleAlgIndexer";
 import { SimultaneousMoveIndexer } from "../../../../controllers/indexer/simultaneous-moves/SimultaneousMoveIndexer";
 import { TreeAlgIndexer } from "../../../../controllers/indexer/tree/TreeAlgIndexer";
@@ -20,6 +20,9 @@ interface IndexerConstructorPropInputs {
   indexerConstructorRequest: IndexerStrategyName;
 }
 
+// `SimultaneousMoveIndexer` is currently not optimized and has to expand the alg. This bounds the number of moves in the expanded alg.
+const SIMULTANEOUS_INDEXER_MAX_EXPANDED_LEAVES = 256;
+
 // TODO: Also handle PG3D vs. 3D
 export class IndexerConstructorProp extends TwistyPropDerived<
   IndexerConstructorPropInputs,
@@ -29,7 +32,8 @@ export class IndexerConstructorProp extends TwistyPropDerived<
     switch (inputs.indexerConstructorRequest) {
       case "auto":
         if (
-          experimentalCountMoves(inputs.alg.alg) < 100 &&
+          countLeavesInExpansionForSimultaneousMoveIndexer(inputs.alg.alg) <=
+            SIMULTANEOUS_INDEXER_MAX_EXPANDED_LEAVES &&
           inputs.puzzle === "3x3x3" &&
           inputs.visualizationStrategy === "Cube3D"
         ) {