Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify parameter validation #1192

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Refactor: Simplify parameter validation #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions TM1py/Services/CubeService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@ def update_or_create_rules(self, cube_name: str, rules: Union[str, Rules], **kwa
"""
if isinstance(rules, str):
rules = Rules(rules=rules)
if isinstance(rules, Rules):
pass
else:
if not isinstance(rules, Rules):
raise ValueError('rules must be type str or Rules')

url = format_url("/Cubes('{}')", cube_name)
Expand Down