Unwind consolidations in hier update #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for update_or_create_hierarchy_from_dataframe function Currently update_or_create_hierarchy_from_dataframe() allows complete unwinding of hierarchy, but not specific unwinding for consolidations. The code change would allow a list of elements to be specified a parameter so selective unwinding is allowed. This change also replace the param unwind with unwind_all, used for same purpose. Function is updated to be backward compatible so, using unwind would map the value to unwind_all and continue unwinding the entire hierarchy when True.
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
MariusWirtz
force-pushed
the
unwind-consolidations-in-hier-update
branch
from
af25b76 to
ed0f28c
Compare
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mr-SabyasachiBose I squashed your commits into a single one 1590311 and added an additional one on top af25b76
Please review my changes and approve the PR.
Encouraged by your
joinaddition to theCaseAndSpaceInsensitivesetclass, I updated and made the three utility classes a bit more powerful.I also added test cases for the new
unwind_consolidationsfeature.