Implement Lazy Initialization to Prevent Warnings for Deprecated Services #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to suppress depracation warnings for the majority of users
|
I don't think it would be reasonable to complicate the code and assure thread safety for these two deprecated services. Happy to merge as is. |
MariusWirtz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces lazy initialization for MonitoringService and ServerService, effectively reducing the occurrence of warnings related to these deprecated services. By instantiating these services in TM1Service only when they are actually needed, we minimize the warnings for the majority of use cases where these services are not used.
Furthermore, this PR suppresses expected warnings in tests: This allows the tests to run without cluttering the output with warnings that were anticipated.
Benefits
Cleaner Output: By avoiding unnecessary warnings, the console output during development and testing is cleaner and easier to read.
Focus on warnings where developer action is required.
Thread Safety Consideration
Please note that this implementation is not thread-safe. If needed, we have to rewrite some parts of the PR.