Fix: Improve version checks FileService #1165

onefloid · 2024-10-14T17:44:23Z

This PR improves the version checks in FileService.py and is inspired by issue #1123 :

Fix: setUpV12 should only be called for v12, otherwise every test is skipped in lower versions f12c49d
Fix: Added minimum required versions to file service c13bf1c
Feature: Added optional feature parameter for explaining why TM1pyVersionException is raised bd33d2a
Fix: Raise error if subfolder feature is not supported by version f24c52d
Refactor: Clean up not necessary f-strings e4b4629

I couldn't run the tests against a tm1 server v12.

…skipped in lower versions

Tests/FileService_test.py

MariusWirtz

Nice work! Thank you.

If you agree with the function names, feel free to push another commit.
Otherwise happy to merge.

onefloid added 5 commits October 9, 2024 17:07

Fix: setUpV12 should only be called for v12, otherwise every test is …

f12c49d

…skipped in lower versions

Refactor: Clean up not necessary f-strings

e4b4629

Fix: Added minimum required versions to file service

c13bf1c

Feature: Added feature explanation to TM1pyVersionException

bd33d2a

Fix: Raise error if feature is not supported by version

f24c52d

onefloid mentioned this pull request Oct 14, 2024

Fix: setUpV12 should only be called for v12, otherwise every test is … #1160

Closed

MariusWirtz reviewed Oct 14, 2024

View reviewed changes

Tests/FileService_test.py Outdated Show resolved Hide resolved

MariusWirtz approved these changes Oct 14, 2024

View reviewed changes

Refactor: Renamed skip_test_if_version_... util functions

d344b8d

MariusWirtz merged commit c8bd0ad into cubewise-code:master Oct 15, 2024

Provide feedback