Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new function to create or update a cube rule #1116

Merged
merged 6 commits into from
May 22, 2024

Conversation

jpcaparroz
Copy link
Contributor

Hello!
In one of my personal projects, I really miss a function to update or create rules in a cube. What do you think of this function? Any suggestion?

It would be something that would help me, but maybe it can be written in a better way.

Thanks,
Regards

@fincci
Copy link

fincci commented May 7, 2024

Niiice!

@MariusWirtz
Copy link
Collaborator

Nice work @jpcaparroz.

I have two small change requests.

@jpcaparroz
Copy link
Contributor Author

Incredible!
I'll make these and a few more changes and upload a new commit.

Thanks @MariusWirtz, for your attention.

@jpcaparroz
Copy link
Contributor Author

Hi @MariusWirtz 😄,

I made a few changes to the PR. Do they make sense?
To address your requests, I added some tests for the new function and updated the terminology in the rules.

Thanks, and I hope this works.

@MariusWirtz MariusWirtz merged commit 2318031 into cubewise-code:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants