Fix: Changed setUp and tearDown from class method to object method #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusWirtz
approved these changes
Apr 5, 2024
onefloid
force-pushed
the
issue/changed-test-setUp-and-tearDown-to-object-methods
branch
from
1cecc00 to
4ed02ac
Compare
MariusWirtz
approved these changes
Apr 5, 2024
|
Sorry, the merge was a little bit to fast. There is still a small syntax error in AnnotationService Test. I will provide an patch in an extra PR soonish |
I discovered that only my local copy was affected. Everything is fine in Github. So there is nothing to patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods
setUp()andtearDown()are not meant to be class methods. I have double checked the docs and can't find any reason to declare them as class methods.All tests run without failures after these changes.
This PR contains:
setUp()andtearDown()clstoself