Issue/improve unit testing setup #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusWirtz
approved these changes
Apr 4, 2024
|
Nice contribution. I agree with your ideas re the config.ini Thank you @onefloid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To run the unit tests, you need to customize Tests/config.ini. Since this file is versioned with Git, it ends up in a unclean working directory with changes you don't want to commit. I suggest including only a template file in the repository Tests/config.ini.template
Changes
This pull request includes:
Does it include Breaking Changes?
This PR shouldn't break anything as long as nobody relies on the currently saved config.ini If so, it would be very bad pratice
For people who have overwritten the config.ini locally, a
git pullwould fail as long as the working directory includes the modified config.ini