Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Close jaegertracing#3270: Prevent rollover lookback from passing the …
…Unix epoch Version 1.26 introduced an automatic configuration for the query lookback when using ElasticSearch with aliases enabled. When aliases are enabled, the ES plugin will look back 100 years. This pre-dates the Unix epoch, and while such dates can be modeled as negative timestamps, the model defined in `jaeger/model/time.go` only supports unsigned timestamps. As a result, the 100-year lookback ends up overflowing the time model, resulting in a distant-future lookback date, rather than a distant-past lookback date. While the time model could be updated to support negative timestamps, it seems unlikely that any Jaeger users would reasonably need to search for spans from the 1920s. This reduces the automatic lookback to 50 years to remove the overflow issue while still providing an extremely long search window that should serve even the most ambitious searches of historical trace data.
- Loading branch information