Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table comment annotation #940

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

APPLE4869
Copy link

This resolves #917

It would be useful for many people because table comment is recommended as described in the rails guide.

https://guides.rubyonrails.org/active_record_migrations.html

It's highly recommended to specify comments in migrations for applications with large databases as it helps people to understand data model and generate documentation.

This pull request refers to #851
The above pull request is conflicted and hasn't been fixed for a while.
Therefore I made this pull request.

@ctran
Copy link
Owner

ctran commented Jun 24, 2022

Thanks! Could you resolve the conflicts (probably just need a rebase)?

@ctran ctran changed the title add table comment annotation Add table comment annotation Jun 24, 2022
@ctran ctran changed the title Add table comment annotation feat: add table comment annotation Jun 24, 2022
@APPLE4869 APPLE4869 force-pushed the add_table_comment branch from bf78806 to 3cd2c4c Compare July 23, 2022 01:26
Signed-off-by: Shokei Takanashi <[email protected]>
Signed-off-by: Shokei Takanashi <[email protected]>
@APPLE4869 APPLE4869 force-pushed the add_table_comment branch from 3cd2c4c to 3336c94 Compare July 23, 2022 01:26
@hatsu38
Copy link

hatsu38 commented Mar 28, 2024

@ctran
I think this pull request is ready to be merged. Shall we merge it?
I'm looking forward to this feature being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Support database table comments
3 participants