annotate --routes modifies only routes.rb #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to prevent activerecord model errors when using mongoid for example and calling `annotate --routes`
|
Does this mean I can't do both routes and models now? |
|
Yes, that's what I would expect from:
|
|
I misunderstood the previous behavior. I'll merge this in. Thanks. |
|
@ctran Any updates on the v2.7.3 release? |
|
This means if I |
drwl
added a commit
that referenced
this pull request
Sep 3, 2019
Prior to this change, `Annotate.include_models?` returned the inverse of `Annotate.include_routes?`. This made it so annotating models and routes was not possible to do together. This PR adds an explicit `--models` flag and also adds it the option to `lib/generators/annotate/templates/auto_annotate_models.rake` with the default being set to `false`. Fixes #563 and undoes the bug introduced in #485.
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
Prior to this change, `Annotate.include_models?` returned the inverse of `Annotate.include_routes?`. This made it so annotating models and routes was not possible to do together. This PR adds an explicit `--models` flag and also adds it the option to `lib/generators/annotate/templates/auto_annotate_models.rake` with the default being set to `false`. Fixes ctran#563 and undoes the bug introduced in ctran#485.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Prior to this change, `Annotate.include_models?` returned the inverse of `Annotate.include_routes?`. This made it so annotating models and routes was not possible to do together. This PR adds an explicit `--models` flag and also adds it the option to `lib/generators/annotate/templates/auto_annotate_models.rake` with the default being set to `false`. Fixes ctran#563 and undoes the bug introduced in ctran#485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a proposed solution to #357 and an alternative to the already proposed solution #361.
In #361 it is needed to call
annotate --routes --ignore-modelsto achieve the same as in this change with onlyannotate --routes.