Fix service active check #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The active check now uses the unit loaded status to determine validity. This may not be entirely accurate, but is an improvement that works in most cases given the services we care about.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The active check now uses the unit loaded status to determine validity.
This check may not be generally accurate, but it is an improvement and works in the cases we are concerned about.
Also: The cargo-vendor-filterer crate recently released a new version that requires Rust 1.64. This PR pins our install in the Makefile to the previous v0.5.8 for el8 compat.
Also: Commits the lock file which was missed back in #845
Closes #851