Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trust init error #1038

Merged
merged 16 commits into from
Oct 11, 2024
Merged

Fix trust init error #1038

merged 16 commits into from
Oct 11, 2024

Conversation

jw3
Copy link
Member

@jw3 jw3 commented Oct 7, 2024

Handle leading spaces on sha1 trust hash

The trust init was failing on a rsplit on spaces when the trust fields were separated by more than a single space. Update that to break the parse into multiple split operations that can be trimmed individually.

The debugging process for this made use of Copr, and while doing so it became clear that the number scheme for PR builds needed improved. This updates the format to build 0.PR.COMMIT, which provides a better flow for these temporary versions than the previous 0.0.PR which would require overwriting the same version on every commit and also did not provide any indication in the build where the build originated.

Closes #1036

@jw3 jw3 force-pushed the 1036-fix_trust_init_error branch from 4d3ca4e to b2fc178 Compare October 7, 2024 22:08
@jw3 jw3 force-pushed the 1036-fix_trust_init_error branch 4 times, most recently from a428533 to da3fee1 Compare October 8, 2024 15:05
@jw3 jw3 force-pushed the 1036-fix_trust_init_error branch from da3fee1 to f1bec71 Compare October 8, 2024 15:12
@jw3 jw3 force-pushed the 1036-fix_trust_init_error branch 2 times, most recently from d609731 to 07c5556 Compare October 9, 2024 16:11
@jw3 jw3 marked this pull request as ready for review October 10, 2024 14:42
@jw3 jw3 merged commit ae118c6 into master Oct 11, 2024
37 of 41 checks passed
@jw3 jw3 deleted the 1036-fix_trust_init_error branch October 11, 2024 12:57
@jw3 jw3 mentioned this pull request Jan 1, 2025
jw3 added a commit that referenced this pull request Jan 1, 2025
##
[v1.5.0](https://github.com/ctc-oss/fapolicy-analyzer/releases/tag/v1.5.0)
- 2024-12-31

### Added

- Include the command line based fapolicy Trust DB admin tool in the CLI
RPM distribution.
([#1025](#1025))
- Include the command line based fapolicy profile tool in the CLI RPM
distribution.
([#1040](#1040))
- Include the command line based rule compiler tool in the CLI RPM
distribution.
([#1043](#1043))
- Add friendly messages in case of application crash, with instructions
for bug reporting and trace file.
([#1045](#1045))
- Added fapolicyd cache stats view with text and 2D plots, showing cache
performance.
([#1048](#1048))

### Fixed

- Fixed trust init issue related to sha1 hashes and improved diagnostics
around parsing the trust db entries.
([#1038](#1038))
- Fixed webkit version selection to support both Fedora and EPEL
versions of webkit2.
([#1044](#1044))

### Packaging

- Subpackaged RPM build to support separate CLI and GUI installations.
([#1025](#1025))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fapolicy-analyzer never finishes initializing
1 participant